Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release - version v2.988 #1253

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

gzsombor
Copy link
Member

No description provided.

@gzsombor gzsombor merged commit 59c27f3 into SkyTubeTeam:master Apr 29, 2024
1 check passed
@gzsombor gzsombor deleted the release-v2.988 branch April 30, 2024 08:38
@drogga
Copy link
Contributor

drogga commented May 2, 2024

@gzsombor

https://github.com/SkyTubeTeam/SkyTube/blob/master/README.md#contribute
This project was possible with the support and contribution of numerous volunteers and third-party projects. > Still leads to the dead site: http://skytube-app.com/credits.html, the link should be removed, or replaced for example with (unreliable): https://web.archive.org/web/20220123174541/https://skytube-app.com/credits.html or https://github.com/SkyTubeTeam/SkyTube/graphs/contributors
The dead site's link is also available here and IDK if you can edit to remove it: https://github.com/SkyTubeTeam

Here as well: https://github.com/SkyTubeTeam/SkyTube/deployments/github-pages
and on weblate (the "info" tab).

Also https://github.com/SkyTubeTeam/SkyTube#download > Please add the GH releases direct link to the Oss column, below, before or next to the F-Droid link, example: https://github.com/SkyTubeTeam/SkyTube/releases/download/v2.988/SkyTube-Oss-2.988.apk and btw, the direct ones can probably be replaced with /latest, which you won't have to edit the ReadMe for, every time there's a new release, even tho there are 2 assets (I can't currently provide an example link).

Preferences > About > Credits is clickable and leads to 404: Not Found, because it leads to https://raw.githubusercontent.com/SkyTubeTeam/SkyTube/master/contributors.txt in /app/build.gradle, which .txt file doesn't even exist in the repo and this should've been a link to whatever, instead of using a WebView.
On the same menu/page > Copylefted Libre License:

along with this program. If not, see <https://www.gnu.org/licenses/>
^ isn't this supposed to be clickable ?, because it's broken.

Videos with multi-channel / multilingual audio are not in English, you can check a video by MrBeast when using Dash/HLS (with the "Try newer Video formats" option, which is enabled by default anyway), it's the same in the prev. ver.

Often and in many cases the avatars/logos and channels header image (which is basically unnecessary, so much wasted space on top, with tabs always visible...) no longer seem to load.

@drogga
Copy link
Contributor

drogga commented May 2, 2024

I wonder if any of this also concerns and is problematic for @IzzySoft's repo as well...

I know that most are minor things, except the last part, of which I really didn't wanted to create a separate issue ticket for and I didn't posted in the discussions on purpose (bad experience there in the past).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants