Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Searching for text using a text file that holds few kilobytes of data results in the app become unresponsive, extremely sluggish and very slow.
Cause
The issue is cause by the
EditText.highlightText()
. Whenever a user tries to search for a string, this function tries to finds all instances of the string and replace them withSpannableString
. More specifically,EditText.setText()
function is extremely slow when settingSpannableText
: this function is called for every search instance found.Solution
Instead of highlighting all search instances, the code now just highlights the first result and once the next button is clicked it will highlight the next result and so on.
Additionally
EditText.setText()
function appears to be faster thenBackgroundColorSpan
is used instead ofSpannableText
.