Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Fixed mounter issue inside the _scrollIntoView function #489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 🐛 Fixed mounter issue inside the _scrollIntoView function #489

wants to merge 1 commit into from

Conversation

Sahil-Simform
Copy link
Collaborator

Description

fix: 🐛 Fixed mounter issue inside the _scrollIntoView function

  • Added mounted checks before setState in _scrollIntoView function

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@Sahil-Simform Sahil-Simform force-pushed the fix/scroll_into_view_setState_issue branch from 734a695 to 8b48f0b Compare December 12, 2024 09:07
@Sahil-Simform Sahil-Simform force-pushed the fix/scroll_into_view_setState_issue branch from 8b48f0b to 24e9328 Compare December 20, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sahil-Simform