feat!: putting the replied message widget builder inside the reply message widget #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage widget This allows to keep the scroll action when tapping the reply message. Also I modified the RepliedMessageConfiguration to add a callback for those who what to modify the behaviour of the tap gesture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I put the
repliedMessageWidgetBuilderinside theReplyMessageWidget.This allows to keep the scroll action when tapping the reply message.
Also I modified the
RepliedMessageConfigurationto add a callback for those who what to modify the behaviour of the tap gestureChecklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Migration instructions
If any developer was implementing
RepliedMessageConfiguration.repliedMessageWidgetBuilderthey should know it's now behing theReplyMessageWidgetand not outside, soy they should provide theRepliedMessageConfiguration.onReplyTappedparameter to control the tap action on the replied message.If you want to scroll to the replied message then you don't need to do anything.