Skip to content

Commit

Permalink
Merge pull request #26 from ShwetaChauhan18/fix/jdk_11_support
Browse files Browse the repository at this point in the history
⬆️ Upgrading dependencies and JDK 11
  • Loading branch information
shwetachauhan-simform committed Sep 5, 2021
2 parents 7a81700 + 14907e9 commit 98c96de
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 7 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ The actual features are:

```
dependencies {
implementation 'com.github.simformsolutions:SSCustomBottomNavigation:3.0'
implementation 'com.github.simformsolutions:SSCustomBottomNavigation:3.1'
}
```

Expand Down Expand Up @@ -233,7 +233,7 @@ binding.bottomNavigation.apply {
}
```

### New Way: (3.0 version) If you use latest version then you need to change your implementation
### New Way: (If you use latest version then you need to change your implementation) (>= 3.0 version)

```kotlin

Expand Down
6 changes: 5 additions & 1 deletion app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ android {
minSdkVersion 21
targetSdkVersion 30
versionCode 2
versionName "3.0"
versionName "3.1"
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables.useSupportLibrary = true
}
Expand All @@ -23,6 +23,10 @@ android {
}
}

kotlinOptions {
jvmTarget = '11'
}

dataBinding {
enabled true
}
Expand Down
8 changes: 4 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ buildscript {
ext.kotlin_version = '1.5.30'
repositories {
google()
jcenter()

mavenCentral()
}

dependencies {
classpath 'com.android.tools.build:gradle:7.0.2'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Expand All @@ -18,9 +18,9 @@ buildscript {

allprojects {
repositories {
mavenCentral()
google()
jcenter()

maven { url 'https://jitpack.io' }
}
}

Expand Down
4 changes: 4 additions & 0 deletions custombottomnavigation/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ android {
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
}

kotlinOptions {
jvmTarget = '11'
}
}

dependencies {
Expand Down
2 changes: 2 additions & 0 deletions jitpack.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
jdk:
- openjdk11

0 comments on commit 98c96de

Please sign in to comment.