fix: removed caching for all other panel type for expression except time series

[aniketio-ctrl]

…om graph in v3 | 6484

Summary

Issue: Wrong caching for metric expressions apart from panel type graph in v3
According to current implementation , we are not caching queries, we are only caching expressions, we are caching if the panel type is graph, so if we are not caching single value panel type queries, we should not also be caching the result of the expression.

for eg-
If the expression is 'A+B', caching key would be '+' that dosen't consider the fact that wether A or B were same or not.

So while creating caching keys for expression , added a check if the version is not v4 then don't proceed unless its panelType: Graph

Related Issues / PR's

Fixes #6484

Screenshots

We are getting cached result with actual result which are vague

Affected Areas and Manually Tested Areas

Manually tested Aread ->
1.) Api -> /api/v3/query_range, tested with different panel type and checking wether we were getting correct result or not

---

Important

Fix caching behavior in GenerateKeys of query_builder.go to skip non-graph panel types in non-v4 versions.

• Behavior:
  • In GenerateKeys of query_builder.go, skip caching for expressions if version is not v4 and panel type is not Graph.
• Caching:
  • Ensures caching only for Graph panel type in non-v4 versions to prevent incorrect cache results for other panel types.

^{This description was created by for 9fb7160. It will automatically update as commits are pushed.}

[welcome]

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ srikanthccv
❌ Aniket

---

Aniket seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 9fb7160 in 24 seconds

More details

• Looked at 14 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. pkg/query-service/app/queryBuilder/query_builder.go:444

• Draft comment:
  The condition if params.Version != "v4" && params.CompositeQuery.PanelType != v3.PanelTypeGraph is used to prevent caching for non-graph panel types in v3. Ensure this logic is consistently applied across all relevant sections of the codebase where caching decisions are made.
• Reason this comment was not posted:
  Comment did not seem useful.

2. pkg/query-service/app/queryBuilder/query_builder.go:441

• Draft comment:
  Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_kcYtJwZHBSWRlKEG

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[srikanthccv]

@aniketio-ctrl, please add test and sign cla

signoz/pkg/query-service/app/queryBuilder/query_builder_test.go

Line 800 in 6e27df9

func TestGenerateCacheKeysMetricsBuilder(t *testing.T) {

[aniketio-ctrl]

@aniketio-ctrl, please add test and sign cla

signoz/pkg/query-service/app/queryBuilder/query_builder_test.go

Line 800 in 6e27df9

func TestGenerateCacheKeysMetricsBuilder(t *testing.T) {

Added the testcase please check

[welcome]

Congrats on merging your first pull request!

We here at SigNoz are proud of you! 🥳