Update client readme example to compile with previous API changes #607
+8
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbardal
approved these changes
Dec 13, 2024
| @@ -96,16 +96,15 @@ import ( | |||
| "time" | |||
There was a problem hiding this comment.
Small typo that can be fixed on line 23 here
Comment on lines
-153
to
-164
| func TestEphemeralProxy(t *testing.T) { | ||
| proxy, _ := toxiClient.CreateProxy("test", "", "google.com:80") | ||
| defer proxy.Delete() | ||
|
|
||
| // Test connection through proxy.Listen | ||
| resp, err := http.Get("http://" + proxy.Listen) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } else if resp.StatusCode != 200 { | ||
| t.Fatal("Proxy to google failed:", resp.StatusCode) | ||
| } | ||
| } |
There was a problem hiding this comment.
Since we're planning on cleaning up this test, we could probably get rid of the net/http import as well since this is the only test that uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the full example in the client readme to compile. It was broken and didn't reflect the current API. I also removed an unnecessary example test that wasn't necessary to get a feel for how to use Toxiproxy.