Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue "Get Current Session ID process from Post Purchase Extension Token" #279

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jonaswebdev
Copy link

@jonaswebdev jonaswebdev commented May 29, 2023

WHY are these changes introduced?

Shopify issues an incomplete token/JWT payload from Checkout::PostPurchase::ShouldRender & Checkout::PostPurchase::Render methods on the Post-Purchase Extension.

The "dest" attribute is missing on the JWT payload and should contain the shop domain, so it throws an exception on the Get Current Session ID on the OAuth Process (Class: Shopify\Auth\OAuth, Method: getCurrentSessionId).

I related more details here.

WHAT is this pull request doing?

Workaround to get the shop domain from "input_data" attribute from JWT.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@jonaswebdev
Copy link
Author

I have signed the CLA!

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@jonaswebdev
Copy link
Author

Hi @rafaelstz I invited you to my repository to you have "write access", please review, thank you

@rafaelstz
Copy link

Hi @jonaswebdev, I'm not part of the Shopify team, so I won't be able to approve it.

shopify-api-php v5.1.0 updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants