Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add signature validation #199

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Feature] Add signature validation #199

wants to merge 3 commits into from

Conversation

mkohei
Copy link

@mkohei mkohei commented Jul 13, 2022 •
edited
Loading

WHY are these changes introduced?

Because there is no Signature verification when using app proxy.

WHAT is this pull request doing?

Add Utils::validateSignature($params, $secret)

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@mkohei mkohei requested a review from a team as a code owner July 13, 2022 01:38
@ghost ghost added the cla-needed label Jul 13, 2022
@sebastianpisula
Copy link

great idea! It still works?

@wardwj
Copy link

wardwj commented Feb 11, 2024

Can we get this added? PR is still valid and works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkohei @sebastianpisula @wardwj