Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adapter for HTTP gem #523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

natematykiewicz
Copy link

This PR adds an adapter for the HTTP ruby gem.

I copied a lot from how the Net::HTTP adapter works.

This adapter is a bit difficult, because the HTTP gem has a perform method on its client that takes in a request, builds the connection, and executes it. This means there's not a great way to instantiate a client with a host/port, assert things about its semian_options, and then later actually execute the request.

Typical usage is to call something like HTTP.get(url), which uses this get method, which runs HTTP::Client.new.request(verb, uri).

HTTP::Client.new takes an options argument, but it's just timeout / ssl settings. Nothing regarding the URI.

If anyone has ideas on how to better test that, please let me know. I've run this code in my own project, and it's working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant