Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DISABLE_V8_COMPILE_CACHE=1 for Yarn in CI #2255

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Set DISABLE_V8_COMPILE_CACHE=1 for Yarn in CI #2255

merged 1 commit into from
Jul 4, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jul 4, 2024

We're seeing a common failure recently for Node in CI:

Could not get yarn cache folder path for /home/runner/work/ruby-lsp/ruby-lsp/vscode/.vscode"

https://github.com/Shopify/ruby-lsp/actions/runs/9783340748/job/27011714149

The post at nodejs/node#51555 suggests this may help to avoid it.

@andyw8 andyw8 added chore Chore task vscode This pull request should be included in the VS Code extension's release notes labels Jul 4, 2024
@andyw8 andyw8 requested a review from a team as a code owner July 4, 2024 12:48
@andyw8 andyw8 requested review from st0012 and vinistock July 4, 2024 12:48
@andyw8 andyw8 changed the title Set DISABLE_V8_COMPILE_CACHE=1 for Yarn Set DISABLE_V8_COMPILE_CACHE=1 for Yarn Jul 4, 2024
@andyw8 andyw8 changed the title Set DISABLE_V8_COMPILE_CACHE=1 for Yarn Set DISABLE_V8_COMPILE_CACHE=1 for Yarn in CI Jul 4, 2024
@andyw8 andyw8 force-pushed the andyw8/disable-v8-compile-cache branch 2 times, most recently from ea03219 to baa0ff4 Compare July 4, 2024 13:03
@andyw8 andyw8 force-pushed the andyw8/disable-v8-compile-cache branch from baa0ff4 to cc16f2a Compare July 4, 2024 13:03
st0012
st0012 reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to not caching yarn anymore 🤔

@andyw8
Copy link
Contributor Author

andyw8 commented Jul 4, 2024

@st0012 this is only for the JIT, not the package caching.

It does seem to add about 10s to the build, but we can live with that, since the other parts are much slower.

@andyw8 andyw8 merged commit 896b316 into main Jul 4, 2024
35 checks passed
@andyw8 andyw8 deleted the andyw8/disable-v8-compile-cache branch July 4, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

@vinistock vinistock Awaiting requested review from vinistock vinistock is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
chore Chore task vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @st0012