-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add outdated version info to troubleshooting guide #2060
Open
andyw8
wants to merge
7
commits into
main
Choose a base branch
from
andyw8/add-outdated-version-troubleshooting-notes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fdf122c
Add outdated version info to troubleshooting guide [skip ci]
andyw8 ee65aed
Update TROUBLESHOOTING.md
andyw8 229261e
Update TROUBLESHOOTING.md
andyw8 ec33f9d
Update TROUBLESHOOTING.md
andyw8 8dc72f2
Update TROUBLESHOOTING.md
andyw8 eda9538
Update TROUBLESHOOTING.md
andyw8 484e10b
Update TROUBLESHOOTING.md
andyw8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want to tell folks to pin their Prism version. Once Prism v1 is out, we will relax our constraints and the issue will be greatly mitigated. Then how do we tell everybody to remove this from their gemfiles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not ideal. But in that time between a Prism release and the update to Ruby LSP, it's a lousy experience for developers.
One way to mitigate this could be align with Kevin so that when the next Prism release is ready, we verify it and pre-emptively bump the constraint a day or two before the actual Prism release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be a smoother option. Also, my understanding is that Prism is almost there with the v1.0.0, so this problem might be resolved very soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next release is going to be v1.0.0, so I'll let you know before it goes out and we can test it.