Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go to definition and hover for files containing multibyte characters #2021

Commits on May 8, 2024

  1. Fix definition and hover for files containing multibyte characters

    When a Ruby file contains multibyte characters, the go to definition and
    hover features do not work correctly. This is because the index building
    and document referencing logic does not properly handle multibyte
    characters when calculating offsets.
    This commit fixes the issue by:
    •Updating index building to use character offsets instead of byte
    offsets
    •Modifying document referencing to properly handle multibyte characters
    when mapping between positions and offsets
    •Adding test cases to verify go to definition work with multibyte
    characters
    NotFounds committed May 8, 2024
    Configuration menu
    Copy the full SHA
    077521e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2474c17 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary comment

    NotFounds committed May 8, 2024
    Configuration menu
    Copy the full SHA
    bd5895c View commit details
    Browse the repository at this point in the history
  4. Format

    NotFounds committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1121fa7 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Fix bug

    NotFounds committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e38a505 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97498bf View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Fix the handling of multibyte characters

    When a Ruby file contains multibyte characters (like Japanese, Chinese,
    emoji, etc), the go to definition and hover features do not work
    correctly. Because the document referencing logic does not properly handle
    multibyte characters when calculating offsets.
    
    This commit fixes the issue by:
    *Modifying document referencing to properly handle multibyte characters
    when mapping between positions and offsets
    *Adding test cases to verify go to definition work with multibyte
    characters
    NotFounds committed May 15, 2024
    Configuration menu
    Copy the full SHA
    156971c View commit details
    Browse the repository at this point in the history