-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERB Support #1184
Add ERB Support #1184
Conversation
This pull request is being marked as stale because there was no activity in the last 2 months |
This pull request is being marked as stale because there was no activity in the last 2 months |
Hey @marcoroth! What's the status of this one? I'm really wishing that Ruby LSP supported ERB Lint. |
We are currently missing the right tools to fully provide really useful support for ERB. This PR only adds super basic support. I guess the question is if we want to finish up and merge the most minimalistic ERB support (which is implemented here) or if we should wait until we can build the needed tools. I do have some ideas for the tooling and needed infrastructure, but it needs more coordination and work, which is out of scope for this PR. |
This pull request is being marked as stale because there was no activity in the last 2 months |
Just for the record, I'm working on the infrastructure tooling right now which is needed to support ERB. I will open a new PR once it's ready and properly useable/useful. The current version in this PR is very minimalistic and probably not very useful in real scenarios. |
cc @st0012 since you were hacking on this too. |
It might make sense to catch up and compare notes, thanks @vinistock! @st0012 I'm going to reach out to see if we can combine efforts. |
@marcoroth 👋 just opened my PR: #2235 |
Resolves #1055, depends on Shopify/vscode-ruby-lsp#896
Motivation
Implementation
Automated Tests
Manual Tests