Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERB Support #1184

Closed
wants to merge 7 commits into from
Closed

Add ERB Support #1184

wants to merge 7 commits into from

Conversation

marcoroth
Copy link
Contributor

@marcoroth marcoroth commented Nov 13, 2023

Resolves #1055, depends on Shopify/vscode-ruby-lsp#896

Motivation

Implementation

Automated Tests

Manual Tests

Copy link
Contributor

This pull request is being marked as stale because there was no activity in the last 2 months

Copy link
Contributor

github-actions bot commented Apr 8, 2024

This pull request is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Apr 8, 2024
@natematykiewicz
Copy link
Contributor

Hey @marcoroth! What's the status of this one? I'm really wishing that Ruby LSP supported ERB Lint.

@marcoroth
Copy link
Contributor Author

We are currently missing the right tools to fully provide really useful support for ERB. This PR only adds super basic support.

I guess the question is if we want to finish up and merge the most minimalistic ERB support (which is implemented here) or if we should wait until we can build the needed tools.

I do have some ideas for the tooling and needed infrastructure, but it needs more coordination and work, which is out of scope for this PR.

Copy link
Contributor

This pull request is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Jun 13, 2024
@github-actions github-actions bot closed this Jun 27, 2024
@marcoroth
Copy link
Contributor Author

Just for the record, I'm working on the infrastructure tooling right now which is needed to support ERB. I will open a new PR once it's ready and properly useable/useful.

The current version in this PR is very minimalistic and probably not very useful in real scenarios.

@vinistock
Copy link
Member

cc @st0012 since you were hacking on this too.

@marcoroth
Copy link
Contributor Author

marcoroth commented Jun 28, 2024

It might make sense to catch up and compare notes, thanks @vinistock!

@st0012 I'm going to reach out to see if we can combine efforts.

@st0012
Copy link
Member

st0012 commented Jun 28, 2024

@marcoroth 👋 just opened my PR: #2235
It allows Ruby LSP to start processing erb files and provide existing code navigation features there too. Several features like formatting or linting are still not working tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for providing features on ERB files
4 participants