-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Skeleton PDP first variant redirect #2643
Open
scottdixon
wants to merge
8
commits into
main
Choose a base branch
from
sd-remove-pdp-redirect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
wizardlyhel
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes
scottdixon
commented
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves https://github.com/Shopify/hydrogen-internal/issues/120
WHAT is this pull request doing?
This update removes the redirect by leveraging the Storefront API's new
product.selectedOrFirstAvailableVariant
field.It also updates the
VariantSelector
to accept a new (optional)selectedVariant
prop for default selected values. Since no URL params are set on the initial page load, the variant selector uses these values to highlight selected values.A canonical link has also been added to the product page to avoid SEO issues with multiple URLs pointing to the same place.
HOW to test your changes?
Run the Skeleton PDP locally against a variety of products. Test products with varying options and availability.
Checklist