Improve the types for useOptimisticCart()
#2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
blittle
commented
Jun 21, 2024
frandiox
approved these changes
Jul 3, 2024
| @@ -26,7 +26,7 @@ export function CartMain({layout, cart: originalCart}: CartMainProps) { | |||
| cart && | |||
| Boolean(cart?.discountCodes?.filter((code) => code.applicable)?.length); | |||
| const className = `cart-main ${withDiscount ? 'with-discount' : ''}`; | |||
| const cartHasItems = !!cart && cart.totalQuantity > 0; | |||
| const cartHasItems = cart?.totalQuantity && cart.totalQuantity > 0; | |||
There was a problem hiding this comment.
Maybe rely on the gt operator to narrow the type to boolean instead of boolean | number | undefined?
Suggested change
| const cartHasItems = cart?.totalQuantity && cart.totalQuantity > 0; | |
| const cartHasItems = cart?.totalQuantity > 0; |
There was a problem hiding this comment.
Typescript doesn't like undefined > 0. So it has to be cart?.totalQuantity! > 0
blittle
force-pushed
the
bl-fix-optimistic-cart-types
branch
from
2bf295e
to
0fdf276
Compare
michenly
approved these changes
Jul 9, 2024
Merged
michenly
pushed a commit
that referenced
this pull request
Jul 11, 2024
* Improve the types for `useOptimisticCart()` * Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fix issues in #2132 that also exposed some improvements to be made to the types in
useOptimisticCart().WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist