Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perfkit #2268

Merged
merged 13 commits into from
Jul 9, 2024
Merged

Perfkit #2268

merged 13 commits into from
Jul 9, 2024

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Jun 20, 2024 •
edited
Loading

WHY are these changes introduced?

Allow Core Web Vital metric tracking with PerfKit - Bundle with <Analytics.Provider>, no change required from dev

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@github-actions GitHub Actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@shopify Shopify
Copy link
Contributor

shopify bot commented Jun 20, 2024 •
edited
Loading

Oxygen deployed a preview of your hl-perfkit branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:02 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:02 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:01 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:02 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:01 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:01 PM

Learn more about Hydrogen's GitHub integration.

frandiox
frandiox reviewed Jul 3, 2024
View reviewed changes
packages/hydrogen/src/analytics-manager/PerfKit.tsx Outdated Show resolved Hide resolved
packages/hydrogen/src/analytics-manager/PerfKit.tsx Outdated Show resolved Hide resolved
packages/hydrogen/vitest.setup.ts Outdated Show resolved Hide resolved
@wizardlyhel
Copy link
Contributor Author

No changeset needed for this

@michenly michenly requested a review from frandiox July 9, 2024 19:04
@frandiox frandiox merged commit 4f048f9 into main Jul 9, 2024
13 checks passed
@frandiox frandiox deleted the hl-perfkit branch July 9, 2024 22:24
michenly pushed a commit that referenced this pull request Jul 11, 2024
@wizardlyhel @michenly
Perfkit (#2268)
c094ecc 
* add perfkit

* add spa mode

* working perfkit

* format

* format

* fix test

* Fix test

* set up perfkit in test

* address errors

* guard perfkit

* pinned perfkit version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wizardlyhel @frandiox