Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Fetch Example #2159

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Single Fetch Example #2159

wants to merge 1 commit into from

Conversation

michenly
Copy link
Contributor

WHY are these changes introduced?

This PR aims to try out Remix's Single Fetch featureahead of the release for React Router v7/Remix v3

Close https://github.com/Shopify/hydrogen-internal/issues/108

WHAT is this pull request doing?

Created an unstable example for those who want to try out remix's single fetch with Hydrogen ahead of React Router v7.

  • Turn on single fetch feature flag
  • import single fetch type
  • add nonce to
  • turn on cd's compatibility flag for http_headers_getsetcookie => need to make this configurable

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@shopify Shopify
Copy link
Contributor

shopify bot commented May 28, 2024 •
edited
Loading

Oxygen deployed a preview of your mc-single-fetch branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 30, 2024 9:39 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 30, 2024 9:39 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 30, 2024 9:39 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 30, 2024 9:39 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 30, 2024 9:39 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 2024 6:49 PM

Learn more about Hydrogen's GitHub integration.

@michenly michenly force-pushed the mc-single-fetch branch 3 times, most recently from 4051c89 to 8b90711 Compare May 28, 2024 20:41
@michenly michenly force-pushed the dirty-session branch 2 times, most recently from ec4f1ac to 794cb08 Compare May 29, 2024 00:08
@michenly michenly force-pushed the mc-single-fetch branch 3 times, most recently from 9bd5bda to 1897751 Compare May 29, 2024 22:09
@michenly michenly force-pushed the dirty-session branch 4 times, most recently from 5bed521 to 9e7e023 Compare May 30, 2024 17:25
@michenly
Copy link
Contributor Author

Blocked by Oxygen runtime to upgrade to latest Cloudflare compatibility date and compatibility flags
Issue link

@michenly michenly added the Blocked Progress on this issue is blocked by something outside of our control label May 30, 2024
@michenly michenly force-pushed the mc-single-fetch branch 7 times, most recently from dc1e94e to 061affb Compare May 30, 2024 21:37
Base automatically changed from dirty-session to main June 6, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Blocked Progress on this issue is blocked by something outside of our control
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@michenly