-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 metrics #167
Draft
lavoiesl
wants to merge
8
commits into
v2
Choose a base branch
from
seb-metrics
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
v2 metrics #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wperron
reviewed
Feb 7, 2023
// Set counts the number of unique elements in a group. | ||
Set(ctx context.Context, name string, value string, tags Tags, rate float64) error | ||
// Timing sends timing information, it is an alias for TimeInMilliseconds | ||
Timing(ctx context.Context, name string, value time.Duration, tags Tags, rate float64) error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we keeping this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Timing
is used by the Timer
metric.
…, and tags extraction from the context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant refactor of the
statsd
package.Design principles / Motivation
Backends' features to add prefix, tags, and context extraction should be composable, allowing users to pick and choose what they want from the library.
New features
ContextWithBackend
. If it is not specified, the default backend is still honoured.Breaking changes
NewLogBackend
is replaced withNewLogrusBackend
to better reflect its implementation2.
NewLogBackend
andNewDatadogBackend
no longer have built-in tags extraction from Context, prefix, and default tags. Instead, users should callBackendWithDefaultWrappers
or wrap them manually.Metric
struct to simplify implementationsMockBackend
has replaced themocks.Backend
metrics
, to better reflect that it is not statsd specific.Timer
metric now uses theTiming
function and the redundantTiming
metric has been removed.Backend
signature has changed to receiveTags
maps instead of string slices. String slices are now only created when calling the underlying statsd client.Minor changes
logError
now reports an error instead of a warning when failing to emit a metric.Tags
now has helper methods to merge with other tags and generate a slice of strings.