fix: correct the offset of the mirror #455
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjffun
force-pushed
the
fix/add-correct-offset
branch
from
48bd9c9
to
ecdb715
Compare
zjffun
commented
Oct 30, 2020
| @@ -426,7 +474,7 @@ function resetMirror({mirror, source, options, ...args}) { | |||
| offsetWidth = computedSourceStyles.getPropertyValue('width'); | |||
| } | |||
|
|
|||
| mirror.style.display = null; | |||
| mirror.style.display = ''; | |||
There was a problem hiding this comment.
A style declaration is reset by setting it to
nullor an empty string, e.g.,elt.style.color = null. Internet Explorer requires setting it to an empty string, and does not do anything when setting it tonull.
zjffun
commented
Feb 15, 2022
| if ( | ||
| (containerStyle.transform && containerStyle.transform !== 'none') || | ||
| (containerStyle.perspective && containerStyle.perspective !== 'none') || | ||
| (containerStyle.filter && containerStyle.filter !== 'none') |
There was a problem hiding this comment.
(containerStyle.backdropFilter && containerStyle.backdropFilter !== 'none')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements or fixes... (explain your changes)
Fix the offset of the mirror and the set value for the mirror
display.Reproduction: https://codepen.io/1010543618/pen/PozRmve
See:
This PR closes the following issues... (if applicable)
#139
Does this PR require the Docs to be updated?
No
Does this PR require new tests?
Because the jsdom used by jest by default is not a real browser environment, it is difficult to write tests.
This branch been tested on... (click all that apply / add new items)
Browsers: