Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable search for dev stores #5145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable search for dev stores #5145

wants to merge 1 commit into from

Conversation

amcaplan
Copy link
Contributor

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-app-inner-loop/issues/2455

Allows developers to find dev stores in the list even if they have > 50 stores.

WHAT is this pull request doing?

Enables autocomplete search for dev stores, just as we have for apps.

Note this will only work for BP orgs, it's not implemented for Partner orgs.

How to test your changes?

Using an org with > 50 dev stores, run app dev and search for a store by name that is beyond the first 50.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@amcaplan amcaplan requested a review from a team as a code owner December 24, 2024 10:49
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Dec 24, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.28% (-0.03% 🔻)
8841/11744
🟡 Branches
70.54% (-0.03% 🔻)
4291/6083
🟡 Functions
75.13% (-0.07% 🔻)
2314/3080
🟡 Lines
75.82% (-0.02% 🔻)
8358/11024
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / dev.ts
72% (-5.78% 🔻)
65.22% (+0.22% 🔼)
72.22% (-9.03% 🔻)
68.18% (-6.18% 🔻)
🟢
... / select-store.ts
83.67% (-1.74% 🔻)
81.82%
71.43% (-11.9% 🔻)
84.78% (-1.88% 🔻)
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
90.48% 98.61%
🔴
... / app-management-client.ts
29.52%
16.83% (-0.34% 🔻)
31.25% 28.4%

Test suite run success

1994 tests passing in 900 suites.

Report generated by 🧪jest coverage report action from 0feadff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant