On deploy, make it impossible to deploy when scope is in the toml

[pobed2]

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[pobed2]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• On deploy, make it impossible to deploy when scope is in the toml #5098 👈 (View in Graphite)
• On dev, rewrite scopes to required_scopes #5097
• When creating a new app, default to using required_scopes #5091
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/fs.d.ts

@@ -171,19 +171,12 @@ export declare function fileSize(path: string): Promise<number>;
  * @returns The size of the file in bytes.
  */
 export declare function fileSizeSync(path: string): number;
-/**
- * Synchronously unlink a file at the given path.
- *
- * @param path - Path to the file.
- */
-export declare function unlinkFileSync(path: string): void;
 /**
  * Unlink a file at the given path.
- *
  * @param path - Path to the file.
  * @returns A promise that resolves when the file is unlinked.
  */
-export declare function unlinkFile(path: string): Promise<void>;
+export declare function unlinkFileSync(path: string): void;
 /**
  * Create a read stream for a file with optional options.
  *

packages/cli-kit/dist/public/node/node-package-manager.d.ts

@@ -15,9 +15,6 @@ export declare const bunLockfile = "bun.lockb";
 export declare const pnpmWorkspaceFile = "pnpm-workspace.yaml";
 /** An array containing the lockfiles from all the package managers */
 export declare const lockfiles: Lockfile[];
-export declare const lockfilesByManager: {
-    [key in PackageManager]: Lockfile | undefined;
-};
 export type Lockfile = 'yarn.lock' | 'package-lock.json' | 'pnpm-lock.yaml' | 'bun.lockb';
 /**
  * A union type that represents the type of dependencies in the package.json

packages/cli-kit/dist/public/node/themes/api.d.ts

@@ -1,4 +1,3 @@
-import { MetafieldOwnerType } from '../../../cli/api/graphql/admin/generated/types.js';
 import { AdminSession } from '@shopify/cli-kit/node/session';
 import { Result, Checksum, Key, Theme, ThemeAsset } from '@shopify/cli-kit/node/themes/types';
 export type ThemeParams = Partial<Pick<Theme, 'name' | 'role' | 'processing' | 'src'>>;
@@ -12,14 +11,4 @@ export declare function bulkUploadThemeAssets(id: number, assets: AssetParams[],
 export declare function fetchChecksums(id: number, session: AdminSession): Promise<Checksum[]>;
 export declare function themeUpdate(id: number, params: ThemeParams, session: AdminSession): Promise<Theme | undefined>;
 export declare function themePublish(id: number, session: AdminSession): Promise<Theme | undefined>;
-export declare function themeDelete(id: number, session: AdminSession): Promise<boolean | undefined>;
-export declare function metafieldDefinitionsByOwnerType(type: MetafieldOwnerType, session: AdminSession): Promise<{
-    key: string;
-    namespace: string;
-    name: string;
-    description: string | null | undefined;
-    type: {
-        name: string;
-        category: string;
-    };
-}[]>;
\ No newline at end of file
+export declare function themeDelete(id: number, session: AdminSession): Promise<boolean | undefined>;
\ No newline at end of file

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	75.21%	8770/11661
🟡	Branches	70.5%	4276/6065
🟡	Functions	74.99%	2294/3059
🟡	Lines	75.76%	8292/10945

Test suite run success

1975 tests passing in 896 suites.

Report generated by 🧪jest coverage report action from f6ec633