[Feature] Add shortcut keys to theme dev #4830
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds shortcut keys to the theme dev CLI service. The keys are as follows: e - open theme editor t - preview your theme locally p - preview your theme (share)
Coverage report
Test suite run success1917 tests passing in 870 suites. Report generated by 🧪jest coverage report action from c9b76d3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you suffer from long logs? Do you accidentally close your browser window and have to scroll all the way up in your terminal to find the theme dev links? Look no further than the addition of shortcut keys!
Feedback before official PR
renderLinksmethod but I don't particularly like the way it looks. EX:The render in the terminal normally looks like
Customize your theme at the theme editorbut is nowCustomize your theme at the theme editor - shortcut key "e"WHY are these changes introduced?
Fixes #4713
With the amount of logs
theme devgenerates, it can be difficult to find the original store links such as previewing your theme, or opening the theme editor. Having shortcut keys is a simple way to open the links without needing to physically click on them in the terminal.WHAT is this pull request doing?
Add shortcut keys to the
theme devcommandWe look for keypresses, specifically:
t- opens the theme locallye- opens the theme editorp- opens the share previewwe also look for
ctrl+cto exit the processHow to test your changes?
Pull down the branch
Build the branch
Run the
theme devcommandTry out the shortcut keys. Click some links, save some files, and see that it does not affect anything else running,
ctrl+cout to confirm you can exit the same as before.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist