Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackdays dev console overhaul #4137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Hackdays dev console overhaul #4137

wants to merge 3 commits into from

Conversation

MitchLillie
Copy link
Contributor

@MitchLillie MitchLillie commented Jun 28, 2024

WHY are these changes introduced?

See https://hackdays.shopify.io/projects/18849

WHAT is this pull request doing?

See project and commits for details

How to test your changes?

Remove broken links for pos-ui extensions

  1. Create a POS ui extension
  2. Run dev and open the dev console.
  3. Assert that the POS UI extensions are displayed without links (other than the mobile QR code)

Fix cursor and capitalization styles

  1. Create some extensions
  2. Run dev and open the dev console.
  3. Assert that extension targets are not capitalized, and that only clickable links show the pointer cursor.

Remove unused show/hide methods

  1. Regression.

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.62% (-0.01% 🔻)
7478/10297
🟡 Branches
69.22% (-0.02% 🔻)
3675/5309
🟡 Functions
71.59% (-0.03% 🔻)
1976/2760
🟡 Lines
72.97% (-0.01% 🔻)
7064/9681

Test suite run success

1720 tests passing in 794 suites.

Report generated by 🧪jest coverage report action from 958ce51

@MitchLillie MitchLillie marked this pull request as ready for review July 5, 2024 16:24
Copy link
Contributor

github-actions bot commented Jul 5, 2024

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant