Merge pull request #36 from ShipEngine/jpill/increase-default-timeout…

…-to-60s fix: change default timeout to 60s
ShipEngine · Jan 17, 2024 · ad934a8 · ad934a8
2 parents d0b47db + 7969f00
commit ad934a8
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,3 +6,9 @@
 ### Bug Fixes
 
 * Update publish to Gem API Key ([3f9c8e5](https://github.com/ShipEngine/shipengine-ruby/commit/3f9c8e5eec8147e2fb1b38a114fa0e2ff24a5f9e))
+
+## [1.0.4]
+
+### Changes
+
+* increase default timeout from 30s to 60s
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shipengine_sdk (1.0.3)
+    shipengine_sdk (1.0.4)
       faraday (>= 1.4)
       faraday_middleware (>= 1.0)
       hashie (>= 3.4)

diff --git a/lib/shipengine/configuration.rb b/lib/shipengine/configuration.rb
@@ -8,7 +8,7 @@ def initialize(api_key:, retries: nil, timeout: nil, page_size: nil, base_url: n
       @api_key = api_key
       @base_url = base_url || Constants.base_url
       @retries = retries || 1
-      @timeout = timeout || 30_000
+      @timeout = timeout || 60_000
       @page_size = page_size || 50
       validate
     end

diff --git a/lib/shipengine/version.rb b/lib/shipengine/version.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ShipEngine
-  VERSION = '1.0.3'
+  VERSION = '1.0.4'
 end
diff --git a/test/internal_client/configuration_test.rb b/test/internal_client/configuration_test.rb
@@ -15,7 +15,7 @@
       client = ShipEngine::Client.new('foo')
 
       # the global configuration should not be mutated
-      assert_equal 30_000, client.configuration.timeout
+      assert_equal 60_000, client.configuration.timeout
       assert_equal 50, client.configuration.page_size
     end
     it 'the global config should not be mutated if overridden at method call time' do