refactor: adjust sizing of sidebar menu #1112
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carlosvirreira @jurrejansen, so as we discussed before I was a bit triggered by our sidebar. I feel like the menu items are too huge and the icons are very big and bulky with very wide stroke. Also our icons have different color than the text so that also looks not so great. Especially when i compare it to some other sidebars that look so much cleaner.
Mintlify example:
I also really like how their close/open works.
Also this part is kinda messy in terms of code and I think it should be in general cleaned up and made easier to maintain and work with.
I would also like to consider the idea of using radix icons in the sidebar, as they just work. We dont need to export and do some shenanigans for each icon for it to work. https://www.radix-ui.com/icons
I have deployed this to testapp(https://github.com/Shelf-nu/shelf.nu/actions/runs/9713220465) so u can see it and lmk what u think. Its very experimental for now.