Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getTimeZoneOffset needs to return a double instead of integer at v8 #2811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

queguangwei
Copy link

I found that the return time of the datenum method in Chrome browser is incorrect, consider customizing a getTimeZoneOffset function to fix Date.prototype.getTimezoneOffset() return error value

@SheetJSDev
Copy link
Contributor

This issue was reported to V8 years ago https://bugs.chromium.org/p/v8/issues/detail?id=7863 but it seems like there has been no movement (and unfortunately a large number of issues are reported here).

@queguangwei
Copy link
Author

I see, since v8 does not fix the problem, do we consider fixing the problem in the code.

@koticmit
Copy link

koticmit commented Apr 8, 2024

@SheetJSDev, Would be nice if we get new release with latest commits. Waiting for once of the security fix ReDos in your package to be fixed. They say below that it is fixed in master branch but not yet released. Many thanks if you can do it.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants