Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter 2 null safety migration #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bkayfitz
Copy link

Here are all the changes required to get this great library to run in Flutter 2. Most of these changes were determined from the automated migration tool, but probably still warrants a quick review.

@ralflorent
Copy link

ralflorent commented Jul 9, 2021

Nice work, buddy! I wonder why this PR is not accepted and merged yet. Just guessing...

@brian-kayfitz
Copy link

Hey @ralflorent Thanks for the feedback! Not sure why the PR was not accepted. I'm thinking this package is not really maintained anymore. You can use my fork of this package if you want to run it with Non Nullable Dart.

https://github.com/bkayfitz/flutter_tindercard/tree/null_safety

If there is enough demand I could upload that fork to pub.dev. Though I really would prefer to avoid creating more noise on that site...

@5tigerjelly
Copy link

Thank you @bkayfitz for writing this. For others needing null safety checks you can use the repo directly like this. Uploading to pub.dev could confuse people between this repo and yours. Even though this repo isn't maintained.

dependencies:
  flutter_tindercard:
    git: https://github.com/bkayfitz/flutter_tindercard.git

@brian-kayfitz
Copy link

@5tigerjelly Thanks for the feedback. Its been a long time since I made this change (over a year ago) It seems like we should just upload a new version of this package to pub.dev. Which is unfortunate. I would have preferred to not add more clutter that site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants