Skip to content

fix(deps): update rust crate serde to >=1.0.194 #708

fix(deps): update rust crate serde to >=1.0.194

fix(deps): update rust crate serde to >=1.0.194 #708

Triggered via push January 2, 2024 11:23
Status Failure
Total duration 45s
Artifacts

clippy.yml

on: push
clippy_check
36s
clippy_check
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 2 warnings
use of `unwrap_or_else` to construct default value: src/paths.rs#L262
error: use of `unwrap_or_else` to construct default value --> src/paths.rs:262:14 | 262 | .unwrap_or_else(PathBuf::new) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
non-canonical implementation of `partial_cmp` on an `Ord` type: src/checksum/digest.rs#L116
error: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/checksum/digest.rs:116:1 | 116 | / impl<T> PartialOrd for Digest<T> 117 | | where 118 | | T: Digestable, 119 | | <<T as Digestable>::OutputSize as Add>::Output: ArrayLength<u8>, 120 | | { 121 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 122 | || self.0.partial_cmp(&other.0) 123 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 124 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl note: the lint level is defined here --> src/lib.rs:19:9 | 19 | #![deny(clippy::all)] | ^^^^^^^^^^^ = note: `#[deny(clippy::non_canonical_partial_ord_impl)]` implied by `#[deny(clippy::all)]`
matching over `()` is more explicit: src/checkers/history/operation/mod.rs#L408
error: matching over `()` is more explicit --> src/checkers/history/operation/mod.rs:408:44 | 408 | self.require_latest_version().map(|_| self) | ^ help: use `()` instead of `_`: `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
matching over `()` is more explicit: src/checkers/history/operation/mod.rs#L399
error: matching over `()` is more explicit --> src/checkers/history/operation/mod.rs:399:44 | 399 | self.require_latest_version().map(|_| self) | ^ help: use `()` instead of `_`: `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
use of `or_insert_with` to construct default value: src/checkers/history/operation/v2.rs#L112
error: use of `or_insert_with` to construct default value --> src/checkers/history/operation/v2.rs:112:22 | 112 | .or_insert_with(HashSet::new) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default note: the lint level is defined here --> src/lib.rs:21:9 | 21 | #![deny(clippy::style)] | ^^^^^^^^^^^^^ = note: `#[deny(clippy::unwrap_or_default)]` implied by `#[deny(clippy::style)]`
matching over `()` is more explicit: src/checkers/history/operation/util.rs#L209
error: matching over `()` is more explicit --> src/checkers/history/operation/util.rs:209:23 | 209 | .map(|(count, _)| count) | ^ help: use `()` instead of `_`: `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
matching over `()` is more explicit: src/checkers/history/operation/util.rs#L204
error: matching over `()` is more explicit --> src/checkers/history/operation/util.rs:204:25 | 204 | let (count, _) = acc?; | ^ help: use `()` instead of `_`: `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns note: the lint level is defined here --> src/lib.rs:24:9 | 24 | #![deny(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::ignored_unit_patterns)]` implied by `#[deny(clippy::pedantic)]`
clippy_check
Clippy had exited with the 101 exit code
lint `private_in_public` has been removed: replaced with another group of lints, see RFC <https://rust-lang.github.io/rfcs/2145-type-privacy.html> for more information: src/lib.rs#L46
warning: lint `private_in_public` has been removed: replaced with another group of lints, see RFC <https://rust-lang.github.io/rfcs/2145-type-privacy.html> for more information --> src/lib.rs:46:1 | 46 | private_in_public, | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(renamed_and_removed_lints)]` on by default
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/