Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory design pattern #24

Merged
merged 46 commits into from
Dec 11, 2023
Merged

Factory design pattern #24

merged 46 commits into from
Dec 11, 2023

Conversation

MAfarrag
Copy link
Member

@MAfarrag MAfarrag commented Feb 8, 2023

Design pattern

  • Unify the methods and the method's parameters for all distributions, and create a factory class to call all distributions.

  • Fixes # (issue)

Type of change

Check relevant points.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.

  • Please also list any relevant details for your test configuration

  • Test A

  • Test B

Checklist:

  • updated version number in setup.py/pyproject.toml
  • updated environment.yml and the lock file
  • added changes to History.rst
  • updated the latest version in README file
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (1f6d7d2) 47.21% compared to head (83358a8) 56.35%.

Files Patch % Lines
statista/metrics.py 0.00% 47 Missing ⚠️
statista/eva.py 81.08% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   47.21%   56.35%   +9.13%     
==========================================
  Files           9        9              
  Lines        1366     1306      -60     
==========================================
+ Hits          645      736      +91     
+ Misses        721      570     -151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MAfarrag MAfarrag merged commit e1f3c07 into main Dec 11, 2023
11 of 13 checks passed
@MAfarrag MAfarrag deleted the factory-design-pattern branch December 11, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant