Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netcdf/clean up enhancment #91

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

MAfarrag
Copy link
Member

Description

  • Please include a summary of the change and which issue is fixed.

  • Please also include relevant motivation and context.

  • List any dependencies that are required for this change.

  • Fixes # (issue)

Type of change

Check relevant points.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.

  • Please also list any relevant details for your test configuration

  • Test A

  • Test B

Checklist:

  • updated version number in setup.py/pyproject.toml.
  • updated environment.yml and the lock file.
  • added changes to History.rst.
  • updated the latest version in README file.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • documentation are updated.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 88.54167% with 55 lines in your changes missing coverage. Please review.

Project coverage is 87.95%. Comparing base (585d339) to head (d33f652).
Report is 5 commits behind head on main.

Files Patch % Lines
pyramids/datacube.py 87.28% 30 Missing ⚠️
pyramids/multidataset.py 90.32% 21 Missing ⚠️
pyramids/abstract_dataset.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   85.82%   87.95%   +2.12%     
==========================================
  Files           6       10       +4     
  Lines        1976     2656     +680     
==========================================
+ Hits         1696     2336     +640     
- Misses        280      320      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant