-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py]: add example and docs for casting in edge and chrome #2072
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
The safari stable tests are failing due to an issue in selenium - SeleniumHQ/selenium#14698 which should be fixed once a minor release is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @navin772 !
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Added example for casting in edge and chrome
Types of changes
Checklist
PR Type
Tests, Documentation
Description
pytest
to handle scenarios where no Cast sinks are available.Changes walkthrough 📝
2 files
test_chrome.py
Add casting feature test for Chrome browser
examples/python/tests/browsers/test_chrome.py
test_cast_features
for Chrome.webdriver.Chrome()
to test casting features.test_edge.py
Add casting feature test for Edge browser
examples/python/tests/browsers/test_edge.py
test_cast_features
for Edge.webdriver.Edge()
to test casting features.8 files
chrome.en.md
Update Chrome documentation with Python casting example
website_and_docs/content/documentation/webdriver/browsers/chrome.en.md
chrome.ja.md
Update Chrome documentation with Python casting example in Japanese
website_and_docs/content/documentation/webdriver/browsers/chrome.ja.md
chrome.pt-br.md
Update Chrome documentation with Python casting example in Portuguese
website_and_docs/content/documentation/webdriver/browsers/chrome.pt-br.md
chrome.zh-cn.md
Update Chrome documentation with Python casting example in Chinese
website_and_docs/content/documentation/webdriver/browsers/chrome.zh-cn.md
edge.en.md
Update Edge documentation with Python casting example
website_and_docs/content/documentation/webdriver/browsers/edge.en.md
edge.ja.md
Update Edge documentation with Python casting example in Japanese
website_and_docs/content/documentation/webdriver/browsers/edge.ja.md
edge.pt-br.md
Update Edge documentation with Python casting example in Portuguese
website_and_docs/content/documentation/webdriver/browsers/edge.pt-br.md
edge.zh-cn.md
Update Edge documentation with Python casting example in Chinese
website_and_docs/content/documentation/webdriver/browsers/edge.zh-cn.md