-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py]: add chrome and edge set_permissions docs #2058
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
The safari stable tests are failing due to an issue in selenium - SeleniumHQ/selenium#14698 which should be fixed once a minor release is done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @navin772 !
add chrome and edge set_permissions docs Co-authored-by: Sri Harsha <[email protected]> 9d66c22
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Add chrome and edge
set_permissions
docs. A helper functionget_permission_state
is added to retrieve the permissions currently set.Types of changes
Checklist
PR Type
documentation, tests
Description
get_permission_state
to retrieve current permission states.Changes walkthrough 📝
2 files
test_chrome.py
Add permission setting test and helper function for Chrome
examples/python/tests/browsers/test_chrome.py
get_permission_state
to query permissionstates.
test_edge.py
Add permission setting test and helper function for Edge
examples/python/tests/browsers/test_edge.py
get_permission_state
to query permissionstates.
8 files
chrome.en.md
Update Chrome documentation with Python example
website_and_docs/content/documentation/webdriver/browsers/chrome.en.md
chrome.ja.md
Update Japanese Chrome documentation with Python example
website_and_docs/content/documentation/webdriver/browsers/chrome.ja.md
documentation.
chrome.pt-br.md
Update Portuguese Chrome documentation with Python example
website_and_docs/content/documentation/webdriver/browsers/chrome.pt-br.md
documentation.
chrome.zh-cn.md
Update Chinese Chrome documentation with Python example
website_and_docs/content/documentation/webdriver/browsers/chrome.zh-cn.md
documentation.
edge.en.md
Update Edge documentation with Python example
website_and_docs/content/documentation/webdriver/browsers/edge.en.md
edge.ja.md
Update Japanese Edge documentation with Python example
website_and_docs/content/documentation/webdriver/browsers/edge.ja.md
documentation.
edge.pt-br.md
Update Portuguese Edge documentation with Python example
website_and_docs/content/documentation/webdriver/browsers/edge.pt-br.md
documentation.
edge.zh-cn.md
Update Chinese Edge documentation with Python example
website_and_docs/content/documentation/webdriver/browsers/edge.zh-cn.md
documentation.