-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added se-config.toml Example to Selenium Manager #1991
Added se-config.toml Example to Selenium Manager #1991
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@VietND96 Fails are due to flaky tests: (macos, stable)
and (macos, nightly)
|
I am thinking that beside the TOML config with explanation, should we add another example TOML so that user can get started quickly in their trial? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shbenzer Code LGTM.
Please fix failed checks.
Hi @VietND96, Yes, It would be great if we could provide code samples or boilerplate code to help users get started more easily. I also think that the page Selenium Manager Documentation is quite extensive and could benefit from being split into Let me know what you think! |
contributed code is only a .toml and documentation. |
I agreed to split it into multiple sections. So we will merge this first and improve later. |
Thank you, @shbenzer ! |
[deploy site] Co-authored-by: Viet Nguyen Duc <[email protected]> Co-authored-by: Sri Harsha <[email protected]> a3018fd
User description
Added se-config.toml example to Documentation.
Description
created example_se-config.toml
added example to all translations of Selenium Manager
Motivation and Context
Extends Issue #1496 , will now add what language bindings are available as well.
Types of changes
Checklist
PR Type
Documentation
Description
se-config.toml
file for Selenium Manager with various configuration options.se-config.toml
example.Changes walkthrough 📝
example_se-config.toml
Add example `se-config.toml` for Selenium Manager
examples/python/tests/selenium_manager/example_se-config.toml
selenium_manager.en.md
Add `se-config.toml` example to English documentation
website_and_docs/content/documentation/selenium_manager.en.md
se-config.toml
example.selenium_manager.ja.md
Add `se-config.toml` example to Japanese documentation
website_and_docs/content/documentation/selenium_manager.ja.md
se-config.toml
example.selenium_manager.pt-br.md
Add `se-config.toml` example to Portuguese documentation
website_and_docs/content/documentation/selenium_manager.pt-br.md
se-config.toml
example.selenium_manager.zh-cn.md
Add `se-config.toml` example to Chinese documentation
website_and_docs/content/documentation/selenium_manager.zh-cn.md
se-config.toml
example.