Improve description on extensions/add-ons #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
diemol
requested changes
Dec 18, 2022
There was a problem hiding this comment.
Please check our styles, specifically line length and translations.
|
Thank you, I updated the PR accordingly. Please note that translations are needed for |
titusfortner
requested changes
Dec 20, 2022
website_and_docs/content/documentation/webdriver/browsers/firefox.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/browsers/firefox.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/browsers/chrome.zh-cn.md
Show resolved
Hide resolved
The paragraphs are left untranslated for `ja` and `pt-br`.
Link to the issue in remote webdriver page, and link to the remote webdriver page in each browser specific functionality page.
diemol
approved these changes
Dec 27, 2022
|
@titusfortner any comments before we merge this? |
|
Just pinging this PR, as it's been 2 weeks since the last reply. |
|
Sorry, got lost in the shuffle, I'm digging into docs for other things soon, and I'll catch up on all of it. |
|
Just pinging this PR, as it's been another 2 weeks. |
|
Just pinging this PR, as it's been 1.5 months since the last reply. |
titusfortner
approved these changes
Feb 26, 2023
|
I just resolved the merge conflict, it can be merged now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The lack of documentation results in many previously unresolved questions on Stack Overflow, such as:
Types of changes
Checklist