Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all filtering on recieve buffers #151

Closed
wants to merge 1 commit into from

Conversation

JBernouli
Copy link

Remove filtering on RX messages on receives for 2515 chip

@Pillar1989
Copy link
Member

@JBernouli Can you explain this PR? We'd like to know the basis for your revision.

@JBernouli
Copy link
Author

In the can settings RXB1 and RXB0 control registers are masked with 0x60 and then setting it to 00

00 = Receives all valid messages using either Standard or Extended Identifiers that meet filter criteria;
Extended ID Filter registers, RXFnEID8:RXFnEID0, are applied to the first two bytes of data in
the messages with standard IDs

This resulted in not receiving extended ID Can messages, the change i made allowed that,
i noticed however that you do have the code already in the #DEBUG_RXANY that i didnt see before,

maybe you guys are filtering on purpose? but the filters are never set up as far as i can see.

@MatthewJeffson MatthewJeffson added Seeed_Arduino_CAN Label for Seeed_Arduino_CAN UAY Unassigned yet Pull request Label for pull requests labels Oct 12, 2024
@Lesords Lesords self-assigned this Oct 14, 2024
@Lesords
Copy link

Lesords commented Nov 7, 2024

Hello,

I appreciate what you've done, but I'm not considering merging this code right now.

Since there are still some people who need the filtering feature, what we should consider is to enable the filter settings feature rather than just removing it.

@Lesords Lesords closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull request Label for pull requests Seeed_Arduino_CAN Label for Seeed_Arduino_CAN UAY Unassigned yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants