Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix to Test workflow #403

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AJGranowski
Copy link

@AJGranowski AJGranowski commented Oct 26, 2024

What are these changes?

This change updates the Test workflow to run on ubuntu-latest, ubuntu-24.04, and ubuntu-22.04.
This change also addresses some issues I encountered while making that change.

Why are these changes being made?

  • Update megalinter to v7.12.0. This updates actionlint to v1.7.1, which adds support for the ubuntu-24.04 runner label.
  • Update poetry.lock to address some CVEs.
  • Update ScribeMD/pre-commit-action to fix errors about running on an old Node version.
  • Split the test job into pre-commit, test-action, and notify. This allows us to test the action on a matrix of runners without running ScribeMD/pre-commit-action and ScribeMD/slack-templates multiple times.
  • Remove ubuntu-18.04 and ubuntu-20.04 from the README since ubuntu-18.04 is no-longer supported, and this action doesn't work on ubuntu-20.04.

Notes

@AJGranowski AJGranowski changed the title Update Test Runner Add matrix to Test workflow Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant