-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trivy action to solve TOO MANY REQUESTS issue #1560
Update trivy action to solve TOO MANY REQUESTS issue #1560
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1560 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 29 29
Lines 4868 4868
=======================================
Hits 4504 4504
Misses 364 364 ☔ View full report in Codecov by Sentry. |
Let's wait a bit to marked it as ready for review. The mantainers of the action are still fixing some consecuencies from all this updates they had to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice PR description, thanks for that!
Looks good, just update the sprintlog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, you're good to merge.
Read this before submitting the PR
If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
A few weeks ago, changes in the GitHub policies regarding rate limits caused issues with the Trivy scanner, which downloads its vulnerability database from a Google Artifact by default. This is a quite popular tool, so too many requests from different users where hitting this limit quite easily, breaking several pipelines in different projects, including ours.
This update in the action aims to incorporate optimization in the way the database is handled. Additionally, it allows for declaring several repositories from where to download the vuln database.
The PR updates the action and declares the two official repositories for the DB artifact, it will try to use the default (Google) first, and if fails, will use the mirror in AWS
Ref: aquasecurity/trivy-action#389
2. Jira task / GitHub issue
Link to the github issue or add the Jira task ID here.
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
master
branch: _If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.