Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.cfg and setup.py in favour of pyproj.toml #173

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ESadek-MO
Copy link
Contributor

No description provided.

@ESadek-MO ESadek-MO marked this pull request as draft November 21, 2024 16:23
pyproject.toml Outdated
@@ -176,6 +190,41 @@ known-first-party = ["tephi"]
"ERA001", # Has commented out code
]

[tool.tox]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unusual approach (compare to cf-units or GeoVista). If it isn't working for you, there is no problem with keeping tox.ini.

Copy link
Contributor Author

@ESadek-MO ESadek-MO Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the standard approach, imo at least. However, tox-conda makes it impossible, as it is pinned to tox v3, and pyproject.toml is only support in tox v4.

So I have got to keep it in tox.ini sadly, until we either move from tox or tox-conda updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants