Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepting Ruff, MyPy, NumPydoc pre-commit checks #288

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Accepting Ruff, MyPy, NumPydoc pre-commit checks #288

merged 5 commits into from
Nov 19, 2024

Conversation

HGWright
Copy link
Contributor

🚀 Pull Request

Description

@HGWright HGWright changed the title add checks and exceptions Accepting Ruff, MyPy, NumPydoc pre-commit checks Nov 15, 2024
stephenworsley
stephenworsley requested changes Nov 18, 2024
View reviewed changes
Copy link

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a couple things to tweak and I think it might be worthwhile just doing a little once over to check all the repo-review ignores are still necessary.

LICENSE Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
stephenworsley
stephenworsley approved these changes Nov 18, 2024
View reviewed changes
Copy link

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit fffece4 into SciTools:main Nov 19, 2024
27 checks passed
@HGWright HGWright mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenworsley stephenworsley stephenworsley approved these changes

Assignees
No one assigned
Labels
Type: GHA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HGWright @stephenworsley