Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Change PlateCarree Vector Handling #1926

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

FIX: Change PlateCarree Vector Handling #1926

wants to merge 4 commits into from
+148 −167

Commits on Aug 29, 2023

  1. FIX: Change PlateCarree vector handling 

    If a PlateCarree projection is used for transforming vectors, users
likely have their data in longitude/latitude for the locations and
the measurement of the field is in North/South. To handle this
situation with PlateCarree requires an additional scaling by the
latitude of the point. This also requires some additional care
for handling points near the pole when applying this scaling.
    @greglucas
    greglucas committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2f0f3d3 View commit details
    Browse the repository at this point in the history

  2. MNT: Parameterize transform_vectors tests 

    This adds a parameterization for the vector transform tests on
the boundary.

The previous values were incorrect. They should be at an angle,
not all in vertical/horizontal coordinates. This can be thought of
by "wrapping" around the pole with a vector pointing up and right
at the corner (180, 90) turning into a down and left vector under
transform to stereographic.
    @greglucas
    greglucas committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    234432c View commit details
    Browse the repository at this point in the history

  3. MNT: Combine vector transform tests into a single file 

    Move crs_transform_vectors tests into the test_vector_transforms file.
    @greglucas
    greglucas committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    ac93213 View commit details
    Browse the repository at this point in the history

  4. TST: Updating vector test images 

    Contains the updated images based on the updated vector transform routines.
    @greglucas
    greglucas committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4ef0b66 View commit details
    Browse the repository at this point in the history