Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing weight initializers to follow standard #196

Merged
merged 28 commits into from
Feb 27, 2024

Conversation

Jay-sanjay
Copy link
Contributor

@Jay-sanjay Jay-sanjay commented Jan 21, 2024

checklist for reservoirs

  • DelayLineBackwardReservoir
  • SimpleCycleReservoir
  • CycleJumpsReservoir
  • NullReservoir (from WeightInitializers)
  • RandSparseReservoir
  • PseudoSVDReservoir
  • DelayLineReservoir

checklist for input layers

  • WeightedLayer
  • DenseLayer
  • SparseLayer
  • MinimumLayer (IrrationalSample)
  • MinimumLayer (BernoulliSample)
  • InformedLayer
  • NullLayer (from WeightInitializers)

@Jay-sanjay Jay-sanjay changed the title Patch 1 Changing weight initializers to follow standard Jan 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 84.18803% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 89.07%. Comparing base (fd5e45d) to head (c028bcd).

Files Patch % Lines
src/esn/esn_input_layers.jl 61.66% 23 Missing ⚠️
src/esn/esn_reservoirs.jl 92.10% 6 Missing ⚠️
src/ReservoirComputing.jl 81.81% 2 Missing ⚠️
src/esn/deepesn.jl 83.33% 2 Missing ⚠️
src/esn/esn.jl 88.88% 2 Missing ⚠️
src/esn/hybridesn.jl 94.44% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   86.15%   89.07%   +2.91%     
==========================================
  Files          12       14       +2     
  Lines         650      604      -46     
==========================================
- Hits          560      538      -22     
+ Misses         90       66      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinuzziFrancesco MartinuzziFrancesco marked this pull request as ready for review February 21, 2024 10:15
@MartinuzziFrancesco
Copy link
Collaborator

ok a couple of final changes and this is good to go

@MartinuzziFrancesco
Copy link
Collaborator

MartinuzziFrancesco commented Feb 21, 2024

I'm getting a ArgumentError: invalid Array dimensions when using the formatter, is this an issue with the style? @ChrisRackauckas

solved

@MartinuzziFrancesco
Copy link
Collaborator

ok this is green all around

@MartinuzziFrancesco MartinuzziFrancesco merged commit 746424d into SciML:master Feb 27, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants