Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Documentation updates #182

Merged
merged 6 commits into from
Dec 18, 2023
Merged

[WIP] Documentation updates #182

merged 6 commits into from
Dec 18, 2023

Conversation

MartinuzziFrancesco
Copy link
Collaborator

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the ScioML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d35d844) 86.43% compared to head (b24fbcb) 86.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   86.43%   86.47%   +0.04%     
==========================================
  Files          12       12              
  Lines         597      599       +2     
==========================================
+ Hits          516      518       +2     
  Misses         81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinuzziFrancesco
Copy link
Collaborator Author

@ChrisRackauckas the Downgrade workflow is failing. Is this expected? If not what would the fix be?

@ChrisRackauckas
Copy link
Member

The fix is to fix the lower bounds. You should do that in a separate PR from the docs PR.

@MartinuzziFrancesco
Copy link
Collaborator Author

got it, I will wrap this up and open a new one just for the downgrade

@MartinuzziFrancesco MartinuzziFrancesco merged commit 8098a2d into master Dec 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants