Various improvements #110
Various improvements #110
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 83.76% 82.72% -1.04%
==========================================
Files 4 4
Lines 351 359 +8
==========================================
+ Hits 294 297 +3
- Misses 57 62 +5 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
| TimerOutputs = "0.5" | ||
| Test = "1" | ||
| julia = "1.6" | ||
| julia = "1.10" |
There was a problem hiding this comment.
@ChrisRackauckas is SciML now moving to Julia 1.10 and greater going forward or should this be a lower version cap?
There was a problem hiding this comment.
Yes. Note that there's big discussions of v1.10 being the new LTS. It's not official yet, but we needed to bump a few things (many libraries could no longer support pre-1.9) so since it's 95% sure v1.10 is the new LTS, we're just going to bump it all to v1.10 and hope and pray. If we need to backport any fixes we can but this should drastically simplify things.
There was a problem hiding this comment.
OK, thanks for letting me know. I'll keep this in mind going forward across libraries.
|
I want to merge Torkel's PR first so he doesn't have to deal with rebasing, but then I'll merge this. |
No description provided.