-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: create initialization systems for all problem types. #3253
base: master
Are you sure you want to change the base?
Conversation
If one doesn't change any parameters or initial conditions will initialization still run on every call to |
For clarity, the semantics that we're settling towards is the following:
That makes the easy cases easy, the hard cases possible, and with essentially zero measurable overhead in any case I've tried. |
40b21b6
to
fbfa1c4
Compare
Requires:
|
fbfa1c4
to
88be6f7
Compare
Requires SciML/NonlinearSolve.jl#517 for NonlinearSolve |
Working on adding tests/support for initialization of |
MTK tests pass locally. Waiting on DelayDiffEq.jl and NonlinearSolve.jl (via SciML/NonlinearSolve.jl#518) to be tagged to push the changes. The performance issue mentioned above has also been fixed locally. |
88be6f7
to
02bd7a6
Compare
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.