Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend description and name in the same way #3179

Merged

Conversation

hersle
Copy link
Contributor

@hersle hersle commented Nov 4, 2024

Small follow-up to #3132. Changes the behavior of extend(sys, basesys) to inherit the description of sys, following the same pattern as name. I think this is the better, most consistent and most flexible behavior.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

@ChrisRackauckas ChrisRackauckas merged commit 76805be into SciML:master Nov 4, 2024
31 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants