Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix replace with array dependent parameters #2933

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

AayushSabharwal
Copy link
Member

Close #2932

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as ready for review August 7, 2024 09:21
@AayushSabharwal
Copy link
Member Author

I haven't added a test because I'm working on removing parameter dependency handling from MTKParameters altogether, and moving it to codegen.

@ChrisRackauckas ChrisRackauckas merged commit 08287a4 into SciML:master Aug 8, 2024
23 checks passed
@AayushSabharwal AayushSabharwal deleted the as/replace-fix branch August 8, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacing tunables of dependent parameter vector fails
2 participants