Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bifurcationkit_ext observable fix #2917

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

jClugstor
Copy link
Contributor

Checklist

  • [ x] Appropriate tests were added
  • [x ] Any code changes were done in a way that does not break public API
  • [ x] All documentation related to code changes were updated
  • [ x] The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • [x ] Any new documentation only uses public API

Additional context

This fixes the error in #2889, but I'm not sure if it's completely correct. e.g. I don't think this would work if the Bifurcation parameter was an observable.

@ChrisRackauckas
Copy link
Member

Make the issue into a test case.

@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review August 6, 2024 20:23
@ChrisRackauckas
Copy link
Member

Test failure looks relevant?

@jClugstor
Copy link
Contributor Author

yeah oops, should work now

@ChrisRackauckas ChrisRackauckas merged commit ca85342 into SciML:master Aug 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants