Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using fully_determined when possible in initialization #2909

Closed
wants to merge 2 commits into from

Conversation

ChrisRackauckas
Copy link
Member

This should give better error messages

@ChrisRackauckas
Copy link
Member Author

I'm not sure this is legal in general. Counting the number of equations does not actually give if fully determined since there might be trivial equations, and the tests suggest that's not too uncommon for initializations? @YingboMa opinion?

@AayushSabharwal
Copy link
Member

What if we make it so that passing fully_determined = missing will try-catch the consistency check and take the appropriate code path?

Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct in general. You should check if the DAE system has finite index.

@ChrisRackauckas
Copy link
Member Author

The DAE system would have to already be structurally simplified at this point, so it should be index 1 or have errored already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants