-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw helpful error when unknowns in the initialization system don't have guesses #2874
Conversation
1a30e25
to
53e2aad
Compare
Thanks, I did notice in a few cases we were missing an error message somewhere but didn't track down the best spot to put it. This looks correct. |
Yeah I'm also not 100% sure where to put it. I guess this applies more generally to any |
But an error at that level might be confusing because people might not understand the lack of contextualization, i.e. it would say "u0 is missing a value", when it means "u0 of the initialization" which means "guess". So I think this has to be specialized. |
Maybe. The stacktrace should be very indicative of the context in such a case, though. |
I am doubtful that this is a good way to fix the issue, at all. It would be better to hit the old error again, instead of throwing a new error a new place. Also, |
Attempt to fix #2873.
First draft is very much a WIP. Want to see which tests fail.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.